Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the recipe noarch #76

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Make the recipe noarch #76

merged 3 commits into from
Aug 9, 2022

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Aug 9, 2022 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@martinRenou
Copy link
Member Author

@conda-forge-admin, please rerender

@philippjfr
Copy link
Contributor

Thanks @martinRenou! Not sure why we hadn't made it noarch already. Will check with some team members and then merge.

@martinRenou martinRenou mentioned this pull request Aug 9, 2022
Closed
@philippjfr
Copy link
Contributor

Thanks again @martinRenou, I'll merge!

@philippjfr philippjfr merged commit 0fb43c2 into conda-forge:main Aug 9, 2022
@martinRenou martinRenou deleted the noarch branch August 9, 2022 14:10
@martinRenou martinRenou mentioned this pull request Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almarklein almarklein Awaiting requested review from almarklein almarklein is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@mattpap mattpap Awaiting requested review from mattpap mattpap is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@philippjfr philippjfr Awaiting requested review from philippjfr philippjfr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinRenou @conda-forge-linter @philippjfr